Skip to content

chore: add wait/ref/get/select to Runner.#300

Merged
k82cn merged 1 commit into
xflops:mainfrom
k82cn:add_new_fn
Jan 15, 2026
Merged

chore: add wait/ref/get/select to Runner.#300
k82cn merged 1 commit into
xflops:mainfrom
k82cn:add_new_fn

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented Jan 15, 2026

No description provided.

Signed-off-by: Klaus Ma <klausm@nvidia.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flamepy library by introducing a suite of new methods to the Runner class, specifically wait, ref, get, and select. These additions aim to simplify and optimize the management of asynchronous operations represented by ObjectFuture instances. By providing batch processing capabilities, developers can more easily coordinate and retrieve results from multiple concurrent tasks, leading to cleaner and potentially more performant code when interacting with the Flame execution environment.

Highlights

  • New Runner Methods: The Runner class now includes new utility methods: get(), ref(), wait(), and select(). These methods streamline the handling of multiple ObjectFuture instances, allowing for batch operations like waiting for completion, retrieving results, or iterating over futures as they complete.
  • ObjectFuture Enhancements: The ObjectFuture class has been extended with a wait() method, enabling explicit waiting for a single future's completion without immediately fetching its result.
  • ObjectFutureIterator Introduction: A new ObjectFutureIterator class has been added, which provides an efficient way to iterate over a collection of ObjectFuture instances as they complete, leveraging concurrent.futures.as_completed.
  • Example and Test Updates: Existing examples and test cases have been updated to demonstrate and utilize these new Runner and ObjectFuture capabilities, replacing individual .get() or .ref() calls with the more efficient batch methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces convenient batch operations get, ref, wait, and select on the Runner class, which simplifies handling multiple ObjectFuture instances. The examples and tests have been updated to use these new APIs. While the new methods are functionally correct, the implementations for get, ref, and wait can be made more efficient by processing futures in parallel rather than sequentially. I've provided suggestions to improve their performance by leveraging Python's concurrent.futures library. The implementation of select is well-done.

Comment thread sdk/python/src/flamepy/runner.py
Comment thread sdk/python/src/flamepy/runner.py
Comment thread sdk/python/src/flamepy/runner.py
@k82cn k82cn merged commit b76802e into xflops:main Jan 15, 2026
4 checks passed
@k82cn k82cn deleted the add_new_fn branch January 15, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant