Skip to content

fix: fix examples/ps error.#328

Merged
k82cn merged 2 commits into
xflops:mainfrom
k82cn:flm_323_3
Jan 25, 2026
Merged

fix: fix examples/ps error.#328
k82cn merged 2 commits into
xflops:mainfrom
k82cn:flm_323_3

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented Jan 25, 2026

No description provided.

Signed-off-by: Klaus Ma <klausm@nvidia.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the Flame framework's operational robustness and developer experience. It streamlines the management of application execution environments by centralizing working and cache directory setup, and introduces greater flexibility for Python SDK users to configure application runners with custom templates. A significant enhancement is also made to the diagnostic capabilities for Python package installations, providing detailed logs. Furthermore, a new, well-documented example for distributed parameter server training is included, demonstrating these improvements in practice.

Highlights

  • Enhanced Working Directory Management: The executor_manager now includes a dedicated function to set up working, temporary, and cache directories (.uv, .pip) for application instances, ensuring a more robust and organized execution environment.
  • Flexible Runner Configuration: The Python SDK introduces FlameContextRunner and integrates runner template configuration into FlameContext, allowing users to specify custom application templates for Runner instances instead of being limited to a hardcoded 'flmrun' template.
  • Improved Package Installation Logging: The Python SDK's package installation process (flamepy.rl.runpy) now redirects all pip output to a dedicated log file, significantly enhancing debugging capabilities for installation failures.
  • New Parameter Server Example Documentation: A comprehensive README.md has been added for the examples/ps directory, detailing the architecture, usage, key concepts, and troubleshooting for the distributed parameter server training example.
  • Parameter Server Example Fixes: The examples/ps project now correctly lists flamepy as a dependency in its pyproject.toml and adjusts the default number of DataWorker instances for clarity and resource efficiency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new parameter server example and makes several improvements to the Python SDK's runner functionality and package installation process. The changes to make the runner's working directory configurable and to improve logging for package installation are great enhancements for usability and debugging. Removing the global logging configuration from the SDK's __init__.py is an important fix that prevents conflicts with user applications. I've left a few comments on the new example's documentation and some opportunities for code refinement.

Comment thread examples/ps/README.md Outdated
Comment thread executor_manager/src/shims/host_shim.rs Outdated
Comment thread sdk/python/src/flamepy/rl/runpy.py Outdated
Signed-off-by: Klaus Ma <klausm@nvidia.com>
@k82cn k82cn merged commit 69f561c into xflops:main Jan 25, 2026
4 checks passed
@k82cn k82cn deleted the flm_323_3 branch January 25, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant