Skip to content

[docker] Add git to flame-executor-manager image#348

Merged
k82cn merged 1 commit into
xflops:mainfrom
k82cn:add-git-to-fem
Feb 6, 2026
Merged

[docker] Add git to flame-executor-manager image#348
k82cn merged 1 commit into
xflops:mainfrom
k82cn:add-git-to-fem

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented Feb 6, 2026

Summary

Add git to flame-executor-manager Docker image to support downloading dependencies via git (e.g., uv with git dependencies in pyproject.toml).

Required for downloading dependencies via git
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates git into the flame-executor-manager Docker image. This enhancement allows the manager to successfully download and resolve project dependencies that are sourced directly from Git repositories, addressing scenarios where tools like uv might require Git-based dependencies specified in pyproject.toml.

Highlights

  • Docker Image Update: The flame-executor-manager Docker image has been updated to include git.
Changelog
  • docker/Dockerfile.fem
    • Added git to the apt-get install command, ensuring it is available within the Docker image.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds git to the flame-executor-manager Docker image, which aligns with the stated goal of supporting uv with git dependencies. The change is minimal and correctly implemented within the existing RUN command, maintaining good Docker image layering practices.

@k82cn k82cn merged commit 3fa0e3e into xflops:main Feb 6, 2026
5 checks passed
@k82cn k82cn deleted the add-git-to-fem branch February 6, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant