Skip to content

fix(cli): fix incorrect display of session creation time#439

Merged
k82cn merged 1 commit intoxflops:mainfrom
jinzhejz:cli_bug_fix
May 8, 2026
Merged

fix(cli): fix incorrect display of session creation time#439
k82cn merged 1 commit intoxflops:mainfrom
jinzhejz:cli_bug_fix

Conversation

@jinzhejz
Copy link
Copy Markdown

@jinzhejz jinzhejz commented May 8, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the parsing of creation_time in the Rust SDK by removing an erroneous multiplication by 1000, ensuring timestamps are correctly interpreted as milliseconds. It also includes regression tests for Session and Application to prevent future regressions. I have no feedback to provide.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/rust/src/client/mod.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jinzhejz
Copy link
Copy Markdown
Author

jinzhejz commented May 8, 2026

RE: Codecov "Patch coverage 0% / 2 lines missing"

This is a CI configuration blindspot, not a missing test.

The 2 changed lines in sdk/rust/src/client/mod.rs are the DateTime::from_timestamp_millis(...) calls in Session::try_from and Application::try_from. Both are
covered by regression tests added in the same commit, which pass locally:

$ cargo test -p flame-rs --lib client::tests
running 2 tests
test client::tests::application_try_from_parses_creation_time_as_millis ... ok
test client::tests::session_try_from_parses_creation_time_as_millis ... ok

test result: ok. 2 passed; 0 failed

The reason Codecov reports 0% is that .github/workflows/code-verify.yaml explicitly excludes flame-rs from both the test run and the tarpaulin step:

- name: Cargo test
  run: cargo test --workspace --exclude flame-rs --exclude cri-rs
- name: Generate coverage report
  run: cargo tarpaulin --workspace --exclude flame-rs --exclude cri-rs ...

So the new tests are never executed in CI → the 2 changed lines have no execution trace → patch coverage reads 0%.

@k82cn k82cn merged commit b59297a into xflops:main May 8, 2026
6 of 7 checks passed
@jinzhejz jinzhejz deleted the cli_bug_fix branch May 9, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants