Skip to content

[codex] add flmexec Runner numpy e2e#469

Merged
k82cn merged 6 commits into
xflops:mainfrom
k82cn:codex/flmexec-runner-numpy-e2e
May 26, 2026
Merged

[codex] add flmexec Runner numpy e2e#469
k82cn merged 6 commits into
xflops:mainfrom
k82cn:codex/flmexec-runner-numpy-e2e

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented May 26, 2026

Summary

  • Add a focused e2e test for the flmexec Python service path.
  • Have the flmexec script start Runner with dependencies=["numpy"].
  • Assert the remote Runner function imports numpy and returns a deterministic result.

Validation

  • python3 -m py_compile e2e/tests/test_flmexec.py
  • cd e2e && uv run --extra dev ruff format --check tests/test_flmexec.py
  • cd e2e && uv run --extra dev ruff check tests/test_flmexec.py
  • cd e2e && uv run --extra dev pytest -vv tests/test_flmexec.py (skipped locally without a running Flame cluster)

Full Docker e2e was not run because flame-console is not running locally.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new end-to-end test file e2e/tests/test_flmexec.py to verify that a Python script executed via flmexec can successfully start a runner with a numpy dependency and retrieve correct results. There are no review comments to address.

@k82cn k82cn marked this pull request as ready for review May 26, 2026 04:18
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
flmexec/src/script/lang/python.rs 87.71% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@k82cn k82cn merged commit 5d138a2 into xflops:main May 26, 2026
6 checks passed
@k82cn k82cn deleted the codex/flmexec-runner-numpy-e2e branch May 26, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant