[codex] Move flmexec Python default local#475
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the definition of the DEFAULT_PYTHON_VERSION constant from the Rust SDK (sdk/rust/src/lib.rs) to the local Python script execution module (flmexec/src/script/lang/python.rs). I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the
flmexecPython fallback version intoflmexecitself and stop exporting that runtime policy from the Rust SDK.Why
DEFAULT_PYTHON_VERSIONis aflmexecfallback decision, not a public Rust SDK contract. Keeping it local preserves the SDK boundary while leavingFLAME_PYTHON_VERSION_ENVexported as the shared environment contract.Validation
cargo check -p flame-rscargo test -p flmexec