Skip to content

[codex] Move flmexec Python default local#475

Merged
k82cn merged 1 commit into
xflops:mainfrom
k82cn:codex/flmexec-python-default-local
May 28, 2026
Merged

[codex] Move flmexec Python default local#475
k82cn merged 1 commit into
xflops:mainfrom
k82cn:codex/flmexec-python-default-local

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented May 28, 2026

Summary

Move the flmexec Python fallback version into flmexec itself and stop exporting that runtime policy from the Rust SDK.

Why

DEFAULT_PYTHON_VERSION is a flmexec fallback decision, not a public Rust SDK contract. Keeping it local preserves the SDK boundary while leaving FLAME_PYTHON_VERSION_ENV exported as the shared environment contract.

Validation

  • cargo check -p flame-rs
  • cargo test -p flmexec

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the definition of the DEFAULT_PYTHON_VERSION constant from the Rust SDK (sdk/rust/src/lib.rs) to the local Python script execution module (flmexec/src/script/lang/python.rs). I have no feedback to provide as there are no review comments.

@k82cn k82cn marked this pull request as ready for review May 28, 2026 07:29
@k82cn k82cn merged commit dd3d060 into xflops:main May 28, 2026
7 checks passed
@k82cn k82cn deleted the codex/flmexec-python-default-local branch May 28, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant