Skip to content

fix: fix board creator permissions on a regular board #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2023
Merged

fix: fix board creator permissions on a regular board #1189

merged 3 commits into from
Mar 6, 2023

Conversation

@CatiaAntunes96
Copy link

@CatiaAntunes96 CatiaAntunes96 commented Mar 6, 2023 •
edited
Loading

Fixes #1186
Fixes #1185

Proposed Changes

  • The creator of a regular board cannot be removed as responsible of that board by anyone, not even by the super admin
  • The creator of a regular board cannot be deleted of that board
  • A super admin can add himself as participant of a regular board.
  • The BoardName component is now receiving as props the title and description, which allows it to become a reusable component for both create SPLIT board and create regular board pages.

This pull request closes #1185
This pull request closes #1186

@CatiaAntunes96 CatiaAntunes96 added bug Something isn't working frontend labels Mar 6, 2023
@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Mar 6, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Mar 6, 2023
nunocaseiro
nunocaseiro previously approved these changes Mar 6, 2023
View reviewed changes
@CatiaAntunes96 CatiaAntunes96 merged commit 9fc2907 into main Mar 6, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the bug/regular-board-responsible branch March 6, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels

bug Something isn't working frontend

Projects

SPLIT • Bugs
Status: Done

Milestone

Full Version

Development

Successfully merging this pull request may close these issues.

[BUG] Regular board delete [BUG] Regular board responsible

3 participants

@CatiaAntunes96 @nunocaseiro