Skip to content

Conversation

@patricia-mdias
Copy link
Contributor

Relates to:

Proposed Changes

  • Extract all the operations and queries on the team user table to a separate module.
  • Add use cases

This pull request closes:

@patricia-mdias patricia-mdias added this to the Full Version milestone Mar 17, 2023
@patricia-mdias patricia-mdias self-assigned this Mar 17, 2023
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should create a new controller for the teamUser that handles all the related endpoints. So the methods that are in the team controller that are related with the teamUser should be moved to the new controller teamUser.controller.ts. You can use the same path as the team controller if you want
The folder's name for this new module should be teamUser. Same for the boardUsers -> boardUser.

@nunocaseiro
Copy link
Contributor

nunocaseiro commented Mar 19, 2023

with this branch when I create a team it doesn't appear on the team's page

Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind delete all the use-cases specific interfaces and replace it by the generic interface UseCase<,>

Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@patricia-mdias patricia-mdias merged commit 42a368d into main Mar 21, 2023
@patricia-mdias patricia-mdias deleted the refactor/team-user-module branch March 21, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants