-
Notifications
You must be signed in to change notification settings - Fork 11
refactor: team user module #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should create a new controller for the teamUser that handles all the related endpoints. So the methods that are in the team controller that are related with the teamUser should be moved to the new controller teamUser.controller.ts. You can use the same path as the team controller if you want
The folder's name for this new module should be teamUser. Same for the boardUsers -> boardUser.
backend/src/modules/teamusers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/create-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/create-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/delete-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/update-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
|
with this branch when I create a team it doesn't appear on the team's page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind delete all the use-cases specific interfaces and replace it by the generic interface UseCase<,>
backend/src/modules/teamUsers/interfaces/applications/team-user.use-case.interface.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/delete-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/update-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Relates to:
Proposed Changes
This pull request closes: