Skip to content

refactor: useTeams custom hook #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 30, 2023
Merged

refactor: useTeams custom hook #1318

merged 21 commits into from
Mar 30, 2023

Conversation

@StereoPT
Copy link
Contributor

@StereoPT StereoPT commented Mar 29, 2023

Relates to:

Fixes:

Proposed Changes

  • Refactored useTeams Custom Hook
    • Split this hook into singular hooks to improve usage
  • Removed duplication of server state by removing server state from recoil and only using react-query
  • Improved requests by adding optimistic updates on some queries.

This pull request closes #1295

@StereoPT StereoPT added bug Something isn't working frontend labels Mar 29, 2023
@StereoPT StereoPT requested a review from a team March 29, 2023 14:28
@StereoPT StereoPT self-assigned this Mar 29, 2023
@StereoPT StereoPT linked an issue Mar 29, 2023 that may be closed by this pull request
[BUG]: React-Query Improvements #1295
Closed
nunocaseiro
nunocaseiro requested changes Mar 30, 2023
View reviewed changes
@StereoPT StereoPT requested a review from nunocaseiro March 30, 2023 13:22
nunocaseiro
nunocaseiro previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

jpvsalvador
jpvsalvador approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@jpvsalvador jpvsalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@StereoPT StereoPT merged commit df0c6dd into main Mar 30, 2023
@StereoPT StereoPT deleted the 1295-bug-react-query-improvements branch March 30, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpvsalvador jpvsalvador jpvsalvador approved these changes

@nunocaseiro nunocaseiro nunocaseiro left review comments

Assignees

@StereoPT StereoPT

Labels

bug Something isn't working frontend

Projects

SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: React-Query Improvements

4 participants

@StereoPT @jpvsalvador @nunocaseiro