cl:avoid c function with valist to method#512
Merged
Conversation
luoliwoshang
force-pushed
the
cl/valit
branch
3 times, most recently
from
fd78ed9 to
375584d
Compare
luoliwoshang
force-pushed
the
cl/valit
branch
3 times, most recently
from
fd437bc to
b586119
Compare
MeteorsLiu
reviewed
Jul 15, 2025
MeteorsLiu
approved these changes
Jul 15, 2025
MeteorsLiu
reviewed
Jul 15, 2025
| { | ||
| "mangle": "esp_log_write", | ||
| "c++": "esp_log_write(esp_log_level_t, const char *, const char *, ...)", | ||
| "go": "(EspLogLevelT).EspLogWrite" |
Contributor
There was a problem hiding this comment.
NOTE(MeteorsLiu): This is the false result, only for cl validating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #510