Skip to content

chore(style): refine some error name #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MeteorsLiu merged 1 commit into from
Jul 29, 2025
Merged

chore(style): refine some error name #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cl/internal/convert/package_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1984,7 +1984,7 @@ func TestImport(t *testing.T) {
loader := convert.NewPkgDepLoader(mod, genPkg)
depPkgs, err := loader.LoadDeps(p.PkgInfo)
p.PkgInfo.Deps = depPkgs
if err != nil && !errors.Is(err, llcppg.ErrConfigError) {
if err != nil && !errors.Is(err, llcppg.ErrConfig) {
t.Fatal(err)
}
_, err = loader.Import("github.com/goplus/invalidpkg")
Expand Down Expand Up @@ -2028,7 +2028,7 @@ func TestImport(t *testing.T) {
},
},
})
if err != nil && !errors.Is(err, llcppg.ErrConfigError) {
if err != nil && !errors.Is(err, llcppg.ErrConfig) {
t.Fatal("NewPackage failed:", err)
}
})
Expand Down
2 changes: 1 addition & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func (c *Config) UnmarshalJSON(data []byte) error {

// when headeronly mode is disabled, libs must not be empty.
if c.Libs == "" && !c.HeaderOnly {
return fmt.Errorf("%w: libs must not be empty", ErrConfigError)
return fmt.Errorf("%w: libs must not be empty", ErrConfig)
}

return nil
Expand Down
4 changes: 2 additions & 2 deletions config/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package config

import "fmt"
import "errors"

var ErrConfigError = fmt.Errorf("failed to unmarshal config")
var ErrConfig = errors.New("failed to unmarshal config")
Loading