Fix JSON field name in README.md: change 'includes' to 'include'#550
Merged
Conversation
Fixed inconsistent JSON field name in line 347 where 'includes' should be 'include' to match the documented configuration format used throughout the codebase. Fixes xgo-dev#549 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit comprehensively fixes all instances where 'includes' was used instead of the correct 'include' field name in JSON configuration examples and documentation text: - Line 347: JSON field name (already fixed) - Line 385: Documentation text describing the configuration - Line 420: JSON example for correct ordering - Line 427: JSON example for incorrect ordering All changes ensure consistency with the actual configuration format used throughout the codebase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 27 27
Lines 2747 2747
=======================================
Hits 2313 2313
Misses 391 391
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed remaining instances of incorrect 'includes' field name in the design documentation: - Line 502: JSON configuration example for libxslt - Line 842: JSON structure example in llcppsigfetch output This ensures complete consistency across all documentation files with the actual configuration format used throughout the codebase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
MeteorsLiu
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed inconsistent JSON field name in README.md where 'includes' should be 'include' to match the documented configuration format.
Changes
Context
All configuration files throughout the codebase use 'include' as the field name for specifying header files, not 'includes'. This change ensures consistency with:
_llcppgtest/libxslt/llcppg.cfgRelated Issue
Fixes #549
🤖 Generated with Claude Code