Skip to content

chore: update llcppg to generate go.mod with goplus/lib v0.3.1#612

Merged
luoliwoshang merged 2 commits into
mainfrom
xgopilot/claude/issue-611-1767086678
Dec 30, 2025
Merged

chore: update llcppg to generate go.mod with goplus/lib v0.3.1#612
luoliwoshang merged 2 commits into
mainfrom
xgopilot/claude/issue-611-1767086678

Conversation

@fennoai
Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot commented Dec 30, 2025

Requested by @luoliwoshang

This PR updates all generated bindings in _cmptest/testdata/ to use the latest version of github.com/goplus/lib (v0.3.1 instead of v0.2.0).

Summary

  • Updated 10 go.mod files from v0.2.0 to v0.3.1
  • Updated corresponding go.sum files via go mod tidy
  • All unit tests pass

Updated Modules

  • cjson/1.7.17 and 1.7.18
  • libxml2/2.13.6
  • libxslt/1.1.42
  • zlib/1.3.1
  • bzip2/1.0.8
  • bzip3/1.5.1
  • sqlite3/3.49.1
  • cargs/1.2.0
  • libtool/2.4.7

Testing

  • Ran unit tests: go test -v ./config ./internal/name ./internal/arg ./internal/unmarshal
  • Ran go fmt ./...
  • Ran go vet ./...

Fixes #611

Updated all generated bindings in _cmptest/testdata/ to use the
latest version of github.com/goplus/lib (v0.3.1 instead of v0.2.0).

This updates 10 modules:
- cjson/1.7.17 and 1.7.18
- libxml2/2.13.6
- libxslt/1.1.42
- zlib/1.3.1
- bzip2/1.0.8
- bzip3/1.5.1
- sqlite3/3.49.1
- cargs/1.2.0
- libtool/2.4.7

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: luoliwoshang <51194195+luoliwoshang@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.74%. Comparing base (39489e1) to head (1415656).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files          27       27           
  Lines        2314     2314           
=======================================
  Hits         1961     1961           
  Misses        310      310           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luoliwoshang
Copy link
Copy Markdown
Contributor

@xgopilot you need update the logic of gen go.mod to use goplus/lib v0.3.1! llcppg's logic!

@fennoai
Copy link
Copy Markdown
Contributor Author

fennoai Bot commented Dec 30, 2025

Summary

I've updated the llcppg generator logic to use goplus/lib v0.3.1 instead of hardcoding v0.2.0.

Changes Made

Updated cl/internal/convert/convert.go:46

  • Changed github.com/goplus/lib@v0.2.0 to github.com/goplus/lib@v0.3.1
  • This is where llcppg generates go.mod files for new bindings

Impact

From now on, whenever llcppg generates bindings, it will automatically use goplus/lib v0.3.1. The existing testdata updates in this PR are correct and consistent with what llcppg will now generate.

Testing

  • ✅ All unit tests pass: go test -v ./config ./internal/name ./internal/arg ./internal/unmarshal
  • ✅ Code formatting: go fmt ./...
  • ✅ Static analysis: go vet ./...

Commit

Pushed commit 1415656 to branch xgopilot/claude/issue-611-1767086678

Update the default goplus/lib version from v0.2.0 to v0.3.1 in the
ModInit function. This ensures all newly generated bindings will use
the latest version of goplus/lib.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: luoliwoshang <51194195+luoliwoshang@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@luoliwoshang luoliwoshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luoliwoshang
Copy link
Copy Markdown
Contributor

@xgopilot this github.com/goplus/lib@v0.2.0 is embed at llcppg/cl/internal/convert/convert.go , this hard code may not good,create an issue to describe it! but current pr is only update , we will discuss this feature at another way.

@fennoai
Copy link
Copy Markdown
Contributor Author

fennoai Bot commented Dec 30, 2025

Issue Created

I've created issue #613 to track the discussion about making the goplus/lib version configurable instead of hardcoded.

Summary

Issue #613: feat: make goplus/lib version configurable instead of hardcoded

The issue describes:

  • Current hardcoded approach in cl/internal/convert/convert.go:46
  • Problems with the hardcoded version
  • Proposed solutions (config file, CLI flag, env var)
  • Benefits of making it configurable

Context

As you mentioned, the current PR #612 focuses on updating the version from v0.2.0 to v0.3.1. The architectural discussion about making the version configurable can now continue in issue #613.

Link: #613

@fennoai fennoai Bot changed the title chore: update generated bindings to use goplus/lib v0.3.1 fix: update llcppg to generate go.mod with goplus/lib v0.3.1 Dec 30, 2025
@xgo-dev xgo-dev deleted a comment from fennoai Bot Dec 30, 2025
@luoliwoshang luoliwoshang changed the title fix: update llcppg to generate go.mod with goplus/lib v0.3.1 chore: update llcppg to generate go.mod with goplus/lib v0.3.1 Dec 30, 2025
@luoliwoshang luoliwoshang merged commit 963086b into main Dec 30, 2025
12 checks passed
@fennoai fennoai Bot deleted the xgopilot/claude/issue-611-1767086678 branch December 30, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update the generated goplus/lib use the latest version

2 participants