Skip to content

ci: move llama model demo out of PR workflow and fix print expectation#1945

Merged
xushiwei merged 2 commits into
xgo-dev:mainfrom
cpunion:codex/ci-model-nightly
Jun 6, 2026
Merged

ci: move llama model demo out of PR workflow and fix print expectation#1945
xushiwei merged 2 commits into
xgo-dev:mainfrom
cpunion:codex/ci-model-nightly

Conversation

@cpunion
Copy link
Copy Markdown
Collaborator

@cpunion cpunion commented Jun 6, 2026

Summary

  • remove the HuggingFace llama model download/artifact dependency from the PR LLGo workflow
  • skip _demo/c/llama2-c during the normal demo sweep because it requires an external model checkpoint
  • add a separate Model Demo workflow that runs the llama demo once daily and can also be triggered manually
  • fix the Go <1.26 builtin print regression tests to expect legacy three-digit exponent padding

Verification

  • bash -n .github/workflows/test_demo.sh
  • git diff --check
  • go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/llgo.yml .github/workflows/model-demo.yml
  • GOTOOLCHAIN=local go test ./test -run TestBuiltinPrintLegacyFloatFormat -count=1
  • Docker CI-like Go 1.24.2 linux/amd64:
    • llgo test -timeout=20m github.com/goplus/llgo/test -run TestBuiltinPrintLegacyFloatFormat
    • llgo test -timeout=20m github.com/goplus/llgo/test/go -run TestBuiltinPrintLegacyExponentWidth

This prevents PR CI from failing on HuggingFace 429s while preserving scheduled coverage for the model-backed demo, and fixes the current main CI print-format failure.

@cpunion cpunion changed the title ci: move model demo out of PR workflow ci: move llama model demo out of PR workflow and fix print expectation Jun 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@xushiwei xushiwei merged commit 44e3c9d into xgo-dev:main Jun 6, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants