Conversation
+ better handling of self-referential span + fix some linting issues
# Conflicts: # CHANGELOG.md # svc/FetchService.ts # svc/README.md # svc/TraceService.ts
lbwexler
added a commit
to xh/toolbox
that referenced
this pull request
Apr 29, 2026
## Summary Adopts the new hoist-react `loadSpec` opt-in (xh/hoist-react#4353) in three example models. Pairs with hoist-react PR xh/hoist-react#4353.
haynesjm42
pushed a commit
that referenced
this pull request
Jun 4, 2026
* Enhance FetchService to auto create spans * + Bugfix for path tag + better handling of self-referential span + fix some linting issues * new LoadSpec spanning API * Tweaks from ATM code review * Tweaks from ATM code review * Remove support for automatically generated spans * Remove support for automatically generated spans * Remove support for automatically generated spans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoadSpecConfig.spanto let callers explicitly seed the parent trace context for a load.FetchServicefalls back toopts.loadSpec?.spanwhenopts.spanis not provided, so fetches inherit the active load's span automatically.