feat: Shift+Tab escape from auto-pairs and indented blocks#360
Merged
Conversation
- Extract shared buildPostSaveState() to fix DRY and TOCTOU race in markSaved/markAutoSaved — isDirty stays true if content diverged during async save - Add reentry guard (isSavingRef) to prevent overlapping save cycles - Wrap per-tab saveToPath in try/catch so one failure doesn't abort loop - Re-read doc state per tab instead of using stale snapshot - Fix initDocument to set lastDiskContent from savedContent - Fix loadContent to preserve filePath when arg is undefined - Clamp autoSaveInterval to safe minimum, use completion-time debounce - Add 13 new tests covering TOCTOU, rejection, missing/divergent state Closes #357 Closes #358
Add Shift+Tab behavior to jump cursor past closing auto-pair characters (brackets, quotes, backticks) and to escape left from indented blocks. Refactor autoPair handlers into focused modules (keyHandler, backtickToggle). Also fix claude-code-action audit-fix workflow (direct_prompt → prompt). Closes #357, closes #358
This was referenced Mar 9, 2026
Owner
Author
|
Merged locally to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyHandler.ts,backtickToggle.ts)direct_prompt→promptforclaude-code-action)Closes #357, closes #358
Test plan
shiftTabJump.test.ts)shiftTabEscape.test.ts)pnpm check:allpasses (lint + coverage + build)(, verify Shift+Tab jumps past)in WYSIWYG