Skip to content

fix: clear conflicting placeholder shortcuts (#440)#447

Merged
xiaolai merged 1 commit intomainfrom
fix/440-shortcut-conflicts
Mar 17, 2026
Merged

fix: clear conflicting placeholder shortcuts (#440)#447
xiaolai merged 1 commit intomainfrom
fix/440-shortcut-conflicts

Conversation

@claude
Copy link
Contributor

@claude claude bot commented Mar 17, 2026

Summary

  • Set defaultKey: "" for tableAlignCenter (Phase 2) and cycleList (Phase 4) placeholders
  • Their previous bindings (Mod-Alt-c, Mod-Alt-l) normalized to the same combos as active codeBlock (Alt-Mod-c) and lineNumbers (Alt-Mod-l) shortcuts
  • Non-conflicting defaults will be chosen when those phases are implemented

Closes #440

Test plan

  • pnpm check:all passes (lint, tests, build)
  • Verify codeBlock shortcut (Alt+Cmd+C) works without conflict warning
  • Verify lineNumbers shortcut (Alt+Cmd+L) works without conflict warning

🤖 Generated with Claude Code

Set defaultKey to "" for `tableAlignCenter` and `cycleList` — their
previous bindings (`Mod-Alt-c`, `Mod-Alt-l`) normalize to the same
key combos as the active `codeBlock` and `lineNumbers` shortcuts,
causing false-positive conflict detection.

Closes #440

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude claude bot enabled auto-merge (squash) March 17, 2026 09:44
@xiaolai xiaolai merged commit 7b0ece4 into main Mar 17, 2026
3 checks passed
@xiaolai xiaolai deleted the fix/440-shortcut-conflicts branch March 20, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[audit] menu-sync: shortcut conflicts between active and Phase 2/4 placeholders

1 participant