fix(a11y): add aria-label to icon-only buttons across plugins#449
Merged
fix(a11y): add aria-label to icon-only buttons across plugins#449
Conversation
Screen readers could not determine the purpose of 15+ icon-only buttons across plugins and components. Plugin buttons also had hardcoded English strings violating the i18n rule. Closes #443 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labelto 15+ icon-only buttons across React components and imperative DOM pluginsi18n.t()calls (i18n compliance)plugin.*translation keys toeditor.jsonfor all 10 localesFiles changed
React components (aria-label added):
HistoryView.tsx— revert/delete snapshot buttonsStatusBarRight.tsx— source/rich-text mode togglePlugin buttons (aria-label + i18n):
diagramExport.ts— Export PNGmermaidPreviewDOM.ts— Zoom out/inpreviewHelpers.ts— Copy/Cancel/SaverenderMarkmapPreview.ts— Fit to viewsourcePeekHeader.ts— Live preview/Cancel/SaveImagePasteToastView.ts— Insert/DismissmermaidPanZoom.ts— Reset zoomaiSuggestion/tiptap.ts— Accept/Reject (already had aria-label, now i18n'd)Locale files (15 new keys each):
src/locales/{en,de,es,fr,it,ja,ko,pt-BR,zh-CN,zh-TW}/editor.jsonTest plan
pnpm check:allpasses (lint, i18n, tests, build)Closes #443
🤖 Generated with Claude Code