fix: remove unused type re-exports, legacy fields, and dead Rust code#450
Merged
fix: remove unused type re-exports, legacy fields, and dead Rust code#450
Conversation
Remove dead code identified in audit issue #445: - Remove unused type re-exports from settingsStore, editorStore, mediaPopupStore - Remove legacy SourcePeekAnchorRect type and anchorRect field from sourcePeekStore - Remove pathSegments from paths barrel export (only used internally) - Remove is_client_connected() dead function from mcp_bridge/commands.rs - Remove never-read fields from ClientConnection and PendingRequest structs - Remove never-read pid/parent_process fields from ClientIdentity - Clean up unused imports (SocketAddr, Instant) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settingsStore,editorStore,mediaPopupStoreSourcePeekAnchorRecttype andanchorRectfield/param fromsourcePeekStorepathSegmentsfrom paths barrel export (only used internally inpaths.ts)is_client_connected()dead function and#[allow(dead_code)]suppressed fields from MCP bridge structsSocketAddr/InstantimportsCloses #445
Test plan
pnpm check:allpasses (lint + tests + coverage + tsc + build)cargo checkcompiles with no new errors (pre-existing sidecar binary issue in CI only)🤖 Generated with Claude Code