fix: validate MCP batch handler array elements at boundary#463
Merged
Conversation
Replace unsafe `as` casts on external MCP input with runtime element validation using a new `requireTypedArray` helper. Also replace `requireString(...) as ParagraphOperation` with `requireEnum` for proper enum validation. Closes #459 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireTypedArray<T>helper tovalidateArgs.tsthat validates each array element with a custom validator function, producing clear indexed error messages (e.g., "invalid operation at index 2: missing required field 'type'")as BatchOperation[],as TableOperation[], andas ListOperation[]casts inbatchEditHandler.tsandbatchOpHandlers.tswith element-level validationrequireString(...) as ParagraphOperationinparagraphHandlers.tswithrequireEnumfor proper enum validationCloses #459
Test plan
requireTypedArraytests pass (valid input, invalid element, non-array input, empty array)batchOpHandlerstests verify malformed operations are rejected with clear error messagesparagraphHandlerstest verifies invalid operation enum is rejectedpnpm check:allpasses (lint + coverage + build)🤖 Generated with Claude Code