fix: register pendingSave around workspace.save and save_as (Closes #982)#983
Merged
Conversation
…loses #982) handleWorkspaceSave and handleWorkspaceSaveAs in the MCP v2 bridge wrote directly via writeTextFile() without registerPendingSave / clearPendingSave coordination. The external file watcher couldn't tell these were our own writes and would prompt the user to reload, potentially discarding the AI's save or interleaved edits. Apply the same register → write → clear (with try/finally) pattern that issue #975 added to document.write, and extend the workspace tests to assert both handlers register and clear the pending save, including when writeTextFile rejects.
Owner
Author
|
✅ VERIFIED — The audit finding is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #982
Summary
handleWorkspaceSaveandhandleWorkspaceSaveAsin the MCP v2 bridge wrote directly viawriteTextFile()with noregisterPendingSave/clearPendingSavecoordination, so the external file watcher would treat our own writes as external changes and prompt the user to reload.document.write.workspace.test.tsto assert the coordination for bothsaveandsave_as, including the rejection path.Test plan
pnpm test src/hooks/mcpBridge/v2/__tests__/workspace.test.ts— 18 tests passpnpm check:all— full gate passes (lint + test + build)grep registerPendingSave src/hooks/mcpBridge/v2/workspace.ts→ 3 matches (import + 2 calls)grep clearPendingSave src/hooks/mcpBridge/v2/workspace.ts→ 3 matches (import + 2 calls)