[codex] Add Grok via unified ACP flow#186
Closed
dreamingOf wants to merge 1 commit into
Closed
Conversation
Author
|
Closing per request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Grok as a first-class ACP agent while keeping it on the existing local ACP registry and binary-cache design.
Details
grok agent stdio) with static platform metadata.~/.grok/config.tomlwith the CLI-compatible[mcp_servers.<name>]shape, reusing the existing canonical MCP conversion where possible.~/.grok/sessions, so reopened sessions can show user/assistant turns instead of an empty conversation.Review Notes
I specifically checked that the implementation does not retain the earlier Grok-only remote registry path: no
GROK_CLI_BASE_URL, stable-channel lookup, dynamic Grok version resolver, orLocalCommandinstall path remains.Validation
cargo fmt --check && cargo checkcargo test grok --libcorepack pnpm eslint src/components/settings/acp-agent-settings.tsx src/components/settings/mcp-settings.tsx src/components/agent-icon.tsx src/lib/types.tscorepack pnpm buildgit diff --check