Make 'perf' friendlier to non-Ubuntu Docker hosts #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian's scripted perf wrapper does not work when run in Docker on a non Debian/Ubuntu host. Specifically it insists on a Debian kernel and perf matching its own naming scheme, and the kernel is an impossibility on eg RH. We don't need kernel symbols, just the userland interface, so any close 'linux-tools-*-generic' will work. Extend the script wrapper to look for these close matches, and install it when building Dockerfile.worker
vibhoothi
approved these changes
Dec 9, 2022
Collaborator
vibhoothi
left a comment
vibhoothi
left a comment
There was a problem hiding this comment.
Thanks for the patch,
Sorry I did not get time to check it in AWCY workers manually pasted and verified it on one of the runners, just realised that the filename should be perf^^,
Great SGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian's scripted perf wrapper does not work when run in Docker on a non Debian/Ubuntu host. Specifically it insists on a Debian kernel and perf matching its own naming scheme, and the kernel is an impossibility on eg RH.
We don't need kernel symbols, just the userland interface, so any close 'linux-tools-*-generic' will work. Extend the script wrapper to look for these close matches, and install this extended perf when building Dockerfile.worker