Skip to content

Fix missing search options#3

Merged
Supamiu merged 3 commits intoxivapi:masterfrom
ayyaruq:fix/missing-search-options
Sep 15, 2018
Merged

Fix missing search options#3
Supamiu merged 3 commits intoxivapi:masterfrom
ayyaruq:fix/missing-search-options

Conversation

@hatt
Copy link
Copy Markdown
Contributor

@hatt hatt commented Sep 15, 2018

Move column to be global, and add tags. Tags doesn't validate the string format, but the documentation includes a link to the GH issue tracking string validation in TypeScript.

@ayyaruq
Copy link
Copy Markdown
Member

ayyaruq commented Sep 15, 2018

MFW people using my laptop and don't sign out of their own GitHub :blobshake:

Copy link
Copy Markdown

@vekien vekien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Supamiu
Copy link
Copy Markdown
Collaborator

Supamiu commented Sep 15, 2018

Please consider following the commit conventions next PR to make sure changelog gets everything right :) I'm going to squash it to one commit but it means one changelog entry only.

@Supamiu Supamiu merged commit a902fda into xivapi:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants