Skip to content

Conversation

@c0reme
Copy link
Collaborator

@c0reme c0reme commented Oct 30, 2025

Noticed something when checking the package on npm, since its typescript - we have to build first.

Add build step before publishing to npm
@kaimoe
Copy link
Member

kaimoe commented Oct 30, 2025

Was just looking into this too. Please mind that npm run build presently errors, at least on my install:

src/lib/assets.ts:16:60 - error TS2322: Type 'AssetQuery' is not assignable to type 'Record<string, unknown>'.
  Index signature for type 'string' is missing in type 'AssetQuery'.

16   const { data, errors } = await request({ path: "/asset", params })
                                                              ~~~~~~

  src/utils.ts:17:3
    17   params?: Record<string, unknown>;
         ~~~~~~
    The expected type comes from property 'params' which is declared here on type 'RequestPayload'

src/lib/assets.ts:30:64 - error TS2322: Type 'MapPath & VersionQuery & Pick<AssetQuery, "format">' is not assignable to type 'Record<string, unknown> | undefined'.
  Type 'MapPath & VersionQuery & Pick<AssetQuery, "format">' is not assignable to type 'Record<string, unknown>'.
    Index signature for type 'string' is missing in type 'MapPath & VersionQuery & Pick<AssetQuery, "format">'.

30   const { data, errors } = await request({ path: "/asset/map", params })
                                                                  ~~~~~~

  src/utils.ts:17:3
    17   params?: Record<string, unknown>;
         ~~~~~~
    The expected type comes from property 'params' which is declared here on type 'RequestPayload'


Found 2 errors in the same file, starting at: src/lib/assets.ts:16

@c0reme
Copy link
Collaborator Author

c0reme commented Oct 30, 2025

hmm i thought i fixed that, maybe i didn't push.

@c0reme
Copy link
Collaborator Author

c0reme commented Oct 30, 2025

Should be fixed now

@kaimoe
Copy link
Member

kaimoe commented Oct 30, 2025

Looks good :)

@kaimoe kaimoe merged commit faf5aaf into xivapi:main Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants