Skip to content

chore: add build step #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

chore: add build step #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e83f30
chore: add build step
c0reme Oct 30, 2025
7c12e96
fix: ensure params are correctly typed in asset requests
c0reme Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
node-version: '24.x'
registry-url: 'https://registry.npmjs.org'
- run: npm ci
- run: npm run build
- run: npm publish --provenance --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
4 changes: 2 additions & 2 deletions src/lib/assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class Assets {
* @see https://v2.xivapi.com/api/docs#tag/assets/get/asset
*/
async get(params: Models.AssetQuery): Promise<Buffer> {
const { data, errors } = await request({ path: "/asset", params })
const { data, errors } = await request({ path: "/asset", params: params as unknown as Record<string, unknown> })
if (errors) throw new CustomError(errors[0].message)
return data as Buffer
}
Expand All @@ -27,7 +27,7 @@ export class Assets {
async map(
params: Models.MapPath & Models.VersionQuery & Pick<Models.AssetQuery, "format">
): Promise<Buffer> {
const { data, errors } = await request({ path: "/asset/map", params })
const { data, errors } = await request({ path: "/asset/map", params: params as unknown as Record<string, unknown> })
if (errors) throw new CustomError(errors[0].message)
return data as Buffer
}
Expand Down