Incorrect decode of TP-Originating-Address, TP-User-Data-Header-Indicator and Ucs2#14
Merged
xlab merged 2 commits intoxlab:masterfrom Nov 17, 2018
Merged
Incorrect decode of TP-Originating-Address, TP-User-Data-Header-Indicator and Ucs2#14xlab merged 2 commits intoxlab:masterfrom
xlab merged 2 commits intoxlab:masterfrom
Conversation
xlab
added a commit
that referenced
this pull request
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix decoding of pdu with User-Data-Header such
07919731899699F3440B919781455534F20008811151906461215B0608040A32030304380442044C0020043F0435044004350432043E043400200441043E002004410447043504420430002004320430044804350433043E0020043D043E043C0435044004300020002A003100310035002A00310023
fix checking of Originating-Address's length such
07919731899699F32412D0DA37FB4D7FE76BB81A0008811141901161218A04230020042204150411042F00200031003300340039003904310021041C0415041D042F04190020043D043000200417041E041B041E0422041E00200434043E002000350030002500210421043A04380434043A043800200434043E00200037003000250021000A003500380035007A006F006C006F0074006F0079002E00720075002F006E00760031
useful service for check
https://www.diafaan.com/sms-tutorials/gsm-modem-tutorial/online-sms-pdu-decoder/