Migrate to Go module and add Github action for automated tests#22
Merged
xlab merged 8 commits intoxlab:masterfrom Feb 16, 2022
digineo:go-mod
Merged
Migrate to Go module and add Github action for automated tests#22xlab merged 8 commits intoxlab:masterfrom digineo:go-mod
xlab merged 8 commits intoxlab:masterfrom
digineo:go-mod
Conversation
- always use latest Ubuntu and Go releases - avoid matrices with single entries
- integration_test.go should only run with -tags=integration - make: simplify "go test" call - make: rename "test-integration" task just "integration" - make: add "test" task to run all non-integration tests - make: add "help" task to identify/describe tasks on CLI
Fixes mostly missing periods at the end of sentences (in comments of globals) and misspellings. It also adds t.Parallel() to test files (where appropriate).
Get rid of pesky init() function.
Timestamp parsing is now independent of the host's time zone. Fixes: #23
xlab
approved these changes
Feb 16, 2022
Owner
xlab
left a comment
xlab
left a comment
There was a problem hiding this comment.
Much thanks for this amazing refactoring, I'm glad that the lib was not only useful for someone else but inspired this maintenance. Respect!
Contributor
|
No, thank you for getting this started. I'm currently crunching through the 3GPP TS 23 and 27 series, and I'm glad someone already spent some time to code up semi-octet decoding. We intend to use this library to decode SMS-STATUS-REPORT PDUs only, as we can read AT events from a log file. I've got a WIP branch for this, so expect another PR tomorrow :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.