Skip to content

Conversation

@star-hengxing
Copy link
Member

@star-hengxing star-hengxing marked this pull request as draft April 16, 2025 07:41
@star-hengxing
Copy link
Member Author

@star-hengxing star-hengxing requested a review from waruqi April 16, 2025 09:23
@waruqi
Copy link
Member

waruqi commented Apr 16, 2025

Is it ready now?

@star-hengxing
Copy link
Member Author

Windows ARM can directly run x86 programs, all CI tests passed. Therefore, we need to resolve these two issues first:

  1. Make github-action-setup-xmake support downloading xmake-master.arm64.exe.
download xmake branch master
  downloading from https://github.com/xmake-io/xmake/releases/download/v2.9.9/xmake-master.win32.exe
  downloaded to C:\a\_temp\2a591ff3-434e-4d95-9ad3-4b9231271317.exe
  1. Improve detect.sdks.find_vstudio to allow xmake to locate the Hostarm64 toolchain.
checking for platform ... windows
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\ARM64\cl.exe

@star-hengxing star-hengxing changed the title Add native windows arm64 Add native windows arm64 ci Apr 17, 2025
@waruqi
Copy link
Member

waruqi commented Apr 17, 2025

Windows ARM can directly run x86 programs, all CI tests passed. Therefore, we need to resolve these two issues first:

  1. Make github-action-setup-xmake support downloading xmake-master.arm64.exe.
download xmake branch master
  downloading from https://github.com/xmake-io/xmake/releases/download/v2.9.9/xmake-master.win32.exe
  downloaded to C:\a\_temp\2a591ff3-434e-4d95-9ad3-4b9231271317.exe

我更新了

  1. Improve detect.sdks.find_vstudio to allow xmake to locate the Hostarm64 toolchain.
checking for platform ... windows
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\HostX64\ARM64\cl.exe

现在已经是用 host arch 了,可以等 ci 包更新后再看下,应该是自动切的,不行就提个 pr 过来。

https://github.com/xmake-io/xmake/blob/c5dd3b8bd097d7e2339dea8d5dd94185464a7053/xmake/modules/detect/sdks/find_vstudio.lua#L242

@waruqi waruqi closed this Apr 17, 2025
@waruqi waruqi reopened this Apr 17, 2025
@star-hengxing
Copy link
Member Author

ci stuck, I don't why.

@waruqi
Copy link
Member

waruqi commented Apr 17, 2025

ci stuck, I don't why.

I don't know.

@waruqi
Copy link
Member

waruqi commented Apr 17, 2025

应该是 xmake --version 卡了,不过我没 arm 机器,没法调试

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It should be that xmake --version is stuck, but I don't have an arm machine and I can't debug it

@waruqi
Copy link
Member

waruqi commented Apr 17, 2025

卡在了 https://github.com/xmake-io/xmake/blob/b40e8845aac9c7ddca70994edb7741aec4579b4d/core/src/xmake/engine.c#L1616

不确定是 lua的问题 还是文件访问的系统问题,主入口还没执行到

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Stuck https://github.com/xmake-io/xmake/blob/b40e8845aac9c7ddca70994edb7741aec4579b4d/core/src/xmake/engine.c#L1616

Not sure whether it is a problem with lua or a system problem with file access, the main entrance has not yet been executed

@waruqi
Copy link
Member

waruqi commented Apr 17, 2025

是老问题,tboox/tbox#272 (comment)

之前以为只是 /O1 下的编译器 bug ,现在 arm64 上 /O2 也存在这个优化问题。蛋疼

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It's an old problem, tboox/tbox#272 (comment)

I used to think it was just a compiler bug under /O1, but now there is also this optimization problem on /O2 on arm64. Baby pain

@star-hengxing
Copy link
Member Author

windows ci 都自带 clang,要不换 clang-cl 进行构建?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Windows ci all come with clang, should we change to clang-cl for construction?

@waruqi waruqi marked this pull request as ready for review April 18, 2025 05:41
@waruqi waruqi merged commit 24017f3 into dev Apr 18, 2025
146 of 154 checks passed
@waruqi waruqi deleted the ci branch April 18, 2025 05:41
@waruqi
Copy link
Member

waruqi commented Apr 18, 2025

windows ci 都自带 clang,要不换 clang-cl 进行构建?

好了,clang-cl 暂时不切了,会有不少改动

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Windows ci all come with clang, should we change to clang-cl for construction?

OK, clang-cl is not cut for the time being, there will be many changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants