improve qt xpack

[waruqi]

#7247

[gemini-code-assist]

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances xmake's Qt xpack capabilities by centralizing and improving the management of shared libraries and application resources during the packaging and installation of Qt applications. It introduces new utility functions for comprehensive dependency collection, refactors existing installation logic for better reusability, and specifically addresses the correct deployment structure for macOS .app bundles. These changes lead to more robust and consistent Qt application packaging across various platforms, as demonstrated by the updated test case incorporating an external zlib dependency.

Highlights

• Refactored Shared Library Collection: Common logic for collecting shared library files from targets and their packages has been moved to xmake/modules/private/utils/target.lua, making it reusable across different installation and packaging plugins.
• Enhanced macOS Qt Deployment: The macOS Qt deployment rule (xmake/rules/qt/deploy/macosx.lua) now correctly places application resources into Contents/Resources and shared libraries (including those from xmake packages) into Contents/Frameworks within the .app bundle.
• Improved Cross-Platform Qt Installation: The general Qt installation command (xmake/rules/qt/installcmd.lua) now integrates the new shared library and resource installation utilities, ensuring that external package dependencies (like zlib) and application-specific resources are properly installed alongside Qt components on Windows, Linux, and other platforms.
• Centralized Installation Utilities: Several internal installation utility functions in xmake/plugins/pack/batchcmds.lua have been made public and now utilize the refactored shared library collection logic, streamlining the packaging process.
• Test Case for Zlib Integration: A test application (tests/plugins/pack/qtapp) has been updated to include zlib as a shared dependency, verifying the improved handling of external packages within the Qt xpack.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the xmake build system by integrating zlib for Qt applications, improving package library handling, and refactoring install/uninstall actions for better modularity and maintainability. The changes involve adding zlib as a required package for the qtapp test, introducing new functions for managing target package library files, and updating install/uninstall actions to utilize these functions. Additionally, the macosx deployment rule is updated to handle package libraries. The code has been reviewed, and a critical issue regarding potential function redefinition has been identified and addressed in the review comments.