fix export c++ function symbols

[waruqi]

#7256

[gemini-code-assist]

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where C++ function symbols, especially those that undergo name mangling, were not being properly exported by Xmake's symbol utility functions. The changes refine the symbol filtering logic to ensure that these crucial symbols are correctly included when export_classes is not enabled, thereby improving the robustness of symbol generation for C++ projects.

Highlights

• Refactored Symbol Export Logic: The logic for exporting symbols has been refined to ensure correct handling of C++ function symbols, particularly those that are mangled.
• Improved C++ Function Symbol Export: When the export_classes option is disabled, the system now correctly includes C++ mangled function symbols (e.g., those starting with '?') that were previously filtered out.
• Consistent Application: These changes have been applied uniformly across the _get_allsymbols_by_dumpbin, _get_allsymbols_by_objdump, and _get_allsymbols_by_readsyms utility functions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where C++ function symbols were not being exported correctly when export_classes was set to false. The change correctly adjusts the symbol filtering logic in _get_allsymbols_by_dumpbin, _get_allsymbols_by_objdump, and _get_allsymbols_by_readsyms to include mangled C++ function names. The fix appears correct and addresses the issue. I've also suggested a refactoring to reduce code duplication across these three functions, which would improve maintainability.