Skip to content

improve to select scheme version#7270

Merged
waruqi merged 2 commits intodevfrom
scheme
Jan 27, 2026
Merged

improve to select scheme version#7270
waruqi merged 2 commits intodevfrom
scheme

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 27, 2026

@waruqi waruqi added this to the v3.0.7 milestone Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the package version resolution process within Xmake. It introduces more robust logic for selecting package versions, particularly when dealing with schemes that may not have explicit version lists or when cryptographic verification is not required. The changes ensure a more predictable and flexible version selection, including a new fallback to use the user-specified version under specific conditions.

Highlights

  • Improved Version Selection Logic: Enhanced package version selection logic to prioritize schemes with valid URLs and handle cases where version lists are absent or verification is skipped.
  • Fallback to Required Version: Introduced a fallback mechanism to default to the explicitly required version when no suitable version is found through scheme analysis, aligning with issue #7245 breaks xmake-repo #7265.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fallback mechanism for package version selection, allowing packages to use a specified version from add_requires even if no version is found through existing schemes. A new comment has been added to clarify the logic of a conditional check.

@waruqi waruqi merged commit e4c2c27 into dev Jan 27, 2026
77 of 83 checks passed
@waruqi waruqi deleted the scheme branch January 27, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant