Skip to content

enhance compile_commands support and add test cases#7283

Merged
waruqi merged 4 commits intoxmake-io:devfrom
luadebug:cc
Feb 1, 2026
Merged

enhance compile_commands support and add test cases#7283
waruqi merged 4 commits intoxmake-io:devfrom
luadebug:cc

Conversation

@luadebug
Copy link
Member

@luadebug luadebug commented Jan 30, 2026

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances Xmake's compile_commands support by introducing a new policy that allows developers to control its generation on a per-target basis. It also refines a core utility function, os.isexec, for improved cross-platform compatibility and includes new test cases to ensure the reliability of these changes.

Highlights

  • New Policy for Compile Commands: Introduced a new policy, build.compile_commands, which defaults to true, allowing granular control over the generation of compile_commands.json for individual targets.
  • Conditional Compile Commands Generation: The compile_commands.lua plugin now respects the build.compile_commands policy, enabling users to explicitly disable compile_commands.json output for specific build targets.
  • Enhanced os.isexec Robustness: The os.isexec function in xmake/core/base/os.lua has been improved to gracefully handle scenarios where os._access might not be available, ensuring correct behavior by returning true if the file exists.
  • Comprehensive Test Cases: Added new test cases under tests/projects/policy/compile_commands to thoroughly validate the functionality of the build.compile_commands policy, including scenarios where it is both enabled and disabled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new policy build.compile_commands to selectively disable the generation of compile_commands.json for specific targets. The implementation is sound and is accompanied by a new test case to verify the functionality. I've also noted a small defensive improvement in os.isexec. My only suggestion is a minor cleanup in the new test case to use a newly added source file, which improves clarity. Overall, these are good changes that enhance the flexibility of xmake.

@waruqi waruqi merged commit 4cbe780 into xmake-io:dev Feb 1, 2026
35 checks passed
@waruqi waruqi added this to the v3.0.7 milestone Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants