Feat: Reset password flow #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmachin
requested review from
MBerguer,
chaba11,
lauta2912 and
mlvieras
as code owners
jrg091
reviewed
Dec 4, 2023
jrg091
reviewed
Dec 6, 2023
src/services/user.ts
Outdated
| email, | ||
| }, | ||
| }); | ||
| if (!user) throw new ApiError(errors.INVALID_EMAIL); |
Collaborator
There was a problem hiding this comment.
Let's not tell the potential user whether the email is valid or not
The idea would be to prevent someone to use this feature to confirm whether certain email is from one of our users or not.
jrg091
reviewed
Dec 7, 2023
| ).rejects.toThrow(new ApiError(errors.INVALID_CODE)); | ||
| }); | ||
|
|
||
| test('code is expired', async () => { |
Collaborator
There was a problem hiding this comment.
How about the case the token doesn't exist? 😬
jrg091
approved these changes
Dec 7, 2023
Collaborator
jrg091
left a comment
jrg091
left a comment
There was a problem hiding this comment.
just one small comment on a possible new test and I'm ok to be merged 😬
mlvieras
approved these changes
Jan 11, 2024
Comment on lines
1
to
6
| html | ||
| head | ||
| title #{appName} password reset code | ||
| body | ||
| h1 Hello #{username}, | ||
| p To recover your password use the next code #{code} |
Collaborator
There was a problem hiding this comment.
Suggested change
| html | |
| head | |
| title #{appName} password reset code | |
| body | |
| h1 Hello #{username}, | |
| p To recover your password use the next code #{code} | |
| html | |
| head | |
| title #{appName} password reset code | |
| body | |
| h1 Hello #{username}, | |
| p To recover your password use the next code #{code}. |
gabrielmachin
force-pushed
the
feat/Reset-password-flow
branch
from
da892d2 to
8ee7a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTION Ticket
Type of change
Description of the change
Create flow for updating user password and adding tests for it.
Flow includes requesting an OTP code, which is send through an email, and validating it for updating the password