fix wrong parent of a element where ref another element#86
Merged
Conversation
if a ref element is used inside a sequence, the parent have to be a sequence and not schema.
Member
|
The test you've added makes sense, and since the other tests remain functional I'll approve it. That method call was used to hide an issue related with cloning elements in the reference solving process, and since the other tests work without it it probably means that the issue was since fixed. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a ref element is used inside a sequence, the parent have to be a sequence and not schema.
Could you have a look and see if it’s OK that I’ve deleted that line?
originalReference.getElement().setParentAvailable(false);I couldn’t find out why it was there.