Suggestion for using java.net.URL#87
Merged
Merged
Conversation
It is XML conform to include other schemas with ./location/schema.xsd. The resolving of the location is made by File#getCanonicalPath. Additional http(s) URLs are ignored of resolving relative paths.
writing own url handler to demonstrate inventions of own url schemes
Member
|
Thanks for the suggestion, it looks good, I'll approve it. Will you make more changes or you'd rather that I publish a version with these changes? @waldi5001 |
Contributor
Author
|
Thank you. I think a new version is a gold idea. |
Member
|
@waldi5001 Done, deployed 1.3.0, with both of your fixes and a few other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working with the XsdParser, I came across some issues with location handling, as you can see in my first commit. This gave me the idea not to handle the resolution and normalisation of locations myself. I also noticed that this was being done manually in several places in the code. So I decided to build a version that works exclusively with URLs.
This PR should be seen more as a suggestion. I think there are a few things we could still improve or expand upon should you decide to accept it.