Skip to content

Comments

Support building without XSLT support#173

Merged
hoefling merged 5 commits intoxmlsec:masterfrom
hoefling:no-xslt-support
May 26, 2021
Merged

Support building without XSLT support#173
hoefling merged 5 commits intoxmlsec:masterfrom
hoefling:no-xslt-support

Conversation

@hoefling
Copy link
Member

@hoefling hoefling commented May 26, 2021

Closes #172.

Signed-off-by: oleg.hoefling oleg.hoefling@gmail.com

hoefling added 2 commits May 26, 2021 13:03
@hoefling
add XMLSEC_NO_XSLT check
7e76c45 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling
drop manylinux wheel build for python 3.5
609fac7 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021 •
edited
Loading

Codecov Report

Merging #173 (d697b28) into master (4a91bbc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   88.27%   88.28%   +0.01%     
==========================================
  Files          12       12              
  Lines        2047     2049       +2     
==========================================
+ Hits         1807     1809       +2     
  Misses        240      240
Impacted Files Coverage Δ
src/constants.c 96.38% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a91bbc...d697b28. Read the comment docs.

hoefling added 2 commits May 26, 2021 14:22
@hoefling
prohibit static builds with libxml2-2.9.12, see https://gitlab.gnome.…
db81f9e 
…org/GNOME/libxslt/-/issues/52

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling
adjust to PEP 600 changes
cd7ca85 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling hoefling mentioned this pull request May 26, 2021
Closed
@hoefling hoefling force-pushed the no-xslt-support branch 10 times, most recently from 87db1e3 to 6e0cb0c Compare May 26, 2021 14:54
@hoefling
add linuxbrew build
95ed6fd 
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling hoefling merged commit f6a574f into xmlsec:master May 26, 2021
@hoefling hoefling mentioned this pull request May 27, 2021
Merged
8 tasks
@armenzg
Copy link

armenzg commented May 28, 2021

Hi @hoefling thanks for fixing this!
I'm new to this project. What/when do releases happen?

@hoefling
Copy link
Member Author

hoefling commented May 28, 2021

@armenzg do you need this fix released? I thought this concerns only the (unlikely) case of using linuxbrew and the fix is too insignificant to be released immediately. But of course I can do a 1.3.11 release, somewhere in the upcoming weekend.

@armenzg
Copy link

armenzg commented May 28, 2021

@armenzg do you need this fix released? I thought this concerns only the (unlikely) case of using linuxbrew and the fix is too insignificant to be released immediately. But of course I can do a 1.3.11 release, somewhere in the upcoming weekend.

I can work around it by brew updating and pip installing from this repo's master, however, a release would be nice.
In other words, I'm not blocked since this breakage on Linux and only for the dev env (in production we use apt/Docker vs brew for dev env).

armenzg added a commit to armenzg/sentry that referenced this pull request May 28, 2021
@armenzg
fix(dev): Fix xmlsec installation on Linux
1f86553 
This probably was broken when xmlsec was upgraded few weeks back.
The problem is xmlsec needs newer libraries than the ones brew installs.
We need to update brew and then the newer libraries will be installed.

Other changes to prevent the original regression will be handled on a different PR

See xmlsec/python-xmlsec#173
armenzg added a commit to getsentry/sentry that referenced this pull request May 28, 2021
@armenzg
fix(dev): Fix xmlsec installation on Linux
9f241d3 
This probably was broken when xmlsec was upgraded few weeks back.
The problem is xmlsec needs newer libraries than the ones brew installs.
We need to update brew and then the newer libraries will be installed.

Other changes to prevent the original regression will be handled on a different PR

See xmlsec/python-xmlsec#173
@hoefling hoefling deleted the no-xslt-support branch May 28, 2021 20:17
@hoefling
Copy link
Member Author

hoefling commented May 28, 2021

@armenzg I have released a 1.3.11 containing the fix from this PR. GH releases: 1.3.11, PyPI: 1.3.11.

armenzg added a commit to getsentry/sentry that referenced this pull request May 28, 2021
@armenzg
fix(dev): Fix xmlsec installation on Linux
00669a4 
This probably was broken when xmlsec was upgraded few weeks back.
The problem is xmlsec needs newer libraries than the ones brew installs.
We need to update brew and then the newer libraries will be installed.

Other changes to prevent the original regression will be handled on a different PR

See xmlsec/python-xmlsec#173
@armenzg
Copy link

armenzg commented May 31, 2021

@hoefling that was super! Thank you it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to install xmlsec: xmlSecTransformXsltId undeclared

3 participants

@hoefling @codecov-commenter @armenzg