Merge pull request #55 from xmlunit/placeholders-tweaks

catch and tranform exception when regex pattern is invalid

Author: bodewig

appveyor.yml

@@ -7,6 +7,7 @@ image:
   - Visual Studio 2022
 
 skip_tags: true
+skip_branch_with_pr: true
 
 environment:
   DOTNET_ROLL_FORWARD: Major

src/main/net-placeholders/MatchesRegexPlaceholderHandler.cs

@@ -11,6 +11,7 @@ the License.  You may obtain a copy of the License at
   See the License for the specific language governing permissions and
   limitations under the License.
 */
+using System;
 using System.Text.RegularExpressions;
 using Org.XmlUnit.Diff;
 
@@ -30,12 +31,17 @@ public class MatchesRegexPlaceholderHandler : IPlaceholderHandler {
         public string Keyword { get { return PLACEHOLDER_NAME; } }
         /// <inheritdoc/>
         public ComparisonResult Evaluate(string testText, params string[] args) {
-            if (args.Length > 0 && args[0] != null && args[0] != "") {
-                var pattern = new Regex(args[0].Trim());
-                if (testText != null && Evaluate(testText.Trim(), pattern)) {
-                    return ComparisonResult.EQUAL;
+            if (args.Length > 0 && !string.IsNullOrEmpty(args[0])) {
+                try {
+                    var pattern = new Regex(args[0].Trim());
+                    if (testText != null && Evaluate(testText.Trim(), pattern)) {
+                        return ComparisonResult.EQUAL;
+                    }
+                } catch(ArgumentException e) {
+                    throw new XMLUnitException(e.Message, e);
                 }
             }
+
             return ComparisonResult.DIFFERENT;
         }