Merged
Conversation
| if stepErr != nil { | ||
| w.Status = StatusFailed | ||
|
|
||
| wfErr := fmt.Errorf("workflow failed: step %s: %w", step.Name, stepErr) |
Collaborator
There was a problem hiding this comment.
I would just assign the error without wrapping it as it's implied if w.err != nil then the workflow failed
Collaborator
Author
There was a problem hiding this comment.
i did this to imply a workflow failure not just the step failure message, also to have the step name that caused the failure in the error
AbdelrahmanElawady
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
persisted workflow error as a string
Related issue:
#35