Endian independent host code#31
Endian independent host code#31ed-xmos merged 6 commits intoxmos:developfrom larry-xmos:endian_independent_host
Conversation
xluciano
left a comment
xluciano
left a comment
There was a problem hiding this comment.
The changes look good.
It would be good to check that the DFU host apps build correctly on all the host platform before merging this PR. You could try to run a sw_xvf3510 Jenkins test with this branch of lib_dfu.
Only to allow releasing without this change |
Sure, let me try |
Why should the lib be released without this change? |
Might be to keep the changes in a release to a minimum. Although we can always change our minds and move features around version on anything that hasn't been released it. |
xluciano
left a comment
xluciano
left a comment
There was a problem hiding this comment.
I will approve this PR. I am still of the idea that version v1.0.5 is not necessary, but it is not a critical issue.
Thanks, clearly a matter of convention such as 'increment only on first change since release' I will not merge as per latest instruction but it is ready now that XVF3510 #816 passed tests |
|
Customer verified that this fixed their endianness-related problem |
3 participants
Make suffix generator and verifier byte-order independent so DFU can be deployed on big-endian architectures such as MIPS