Fixes typo in docs workflow.#190
Merged
ed-xmos merged 1 commit intoxmos:developfrom Jul 27, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a copy/paste error in the GitHub actions
docsworkflow where the artifact created for the mic array PDF documentation was titledlib_xcore_math_docs_pdf.Now the two artifacts are
lib_mic_array_docs_htmlandlib_mic_array_docs_pdf, reflecting the documentation type.Note: The
upload-artifactaction always zips the artifact, and as far as I can tell there's no way around that. So for users to view the PDF they unfortunately have to download a zip, extract the pdf, and open that.... instead of just opening the PDF directly in the browser.