Fix filterdesign and enable test#203
Merged
ed-xmos merged 1 commit intoxmos:developfrom Aug 8, 2023
Merged
Conversation
Allan-xmos
approved these changes
Jul 28, 2023
Contributor
Allan-xmos
left a comment
Allan-xmos
left a comment
There was a problem hiding this comment.
Looks good to me. I would keep the warning as a reminder for now. Doing a 5 stage MA filter (needed for 32kHz) results in coefficients with a >int16 dynamic range, which causes the warning and scaling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#201
Note - this does result in:
mic_array/script/filter_design/filter_tools.py:82: UserWarning: max filter coefficient > 2^15, scaling coefficients, some may be lost
warnings.warn("max filter coefficient > 2^15, scaling coefficients, some may be lost")
Which may not be good?