add 48k filter design, small tweak to optimised scaling#206
Merged
Allan-xmos merged 4 commits intoxmos:developfrom Aug 15, 2023
Merged
add 48k filter design, small tweak to optimised scaling#206Allan-xmos merged 4 commits intoxmos:developfrom
Allan-xmos merged 4 commits intoxmos:developfrom
Conversation
ed-xmos
approved these changes
Aug 10, 2023
Contributor
ed-xmos
left a comment
There was a problem hiding this comment.
Changes look OK although I don't really understand the filter design process well enough to comment on the performance so I trust you have this covered.
Only comments are:
- Add a new changelog entry 5.2.0 to say that a 48kHz decimator script has been added
- Bump the module build info https://github.com/xmos/lib_mic_array/blob/develop/lib_mic_array/module_build_info to 5.2.0 also. My bad also - I forgot this for v5.1.0!!
- Add a link in the comments in the design_filter.py script to https://xmosjira.atlassian.net/wiki/spaces/CONF/pages/3805052950/32k+and+48k+Hz+lib+mic+arrayhttps://xmosjira.atlassian.net/wiki/spaces/CONF/pages/3805052950/32k+and+48k+Hz+lib+mic+array
- Do you know roughly what the MIPS increase is for this over 16kHz?
Contributor
Author
As a guesstimate from the table here https://github.com/xmos/lib_mic_array/blob/develop/doc/programming_guide/src/resource_usage.rst :
From that it looks like it might be worth trying a shorter stage 2 filter, so I'll make a "small" version as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.