Add support for XCommon CMake#212
Merged
danielpieczko merged 2 commits intoxmos:feature/xcommon_cmakefrom Nov 3, 2023
danielpieczko:cmake
Merged
Add support for XCommon CMake#212danielpieczko merged 2 commits intoxmos:feature/xcommon_cmakefrom danielpieczko:cmake
danielpieczko merged 2 commits intoxmos:feature/xcommon_cmakefrom
danielpieczko:cmake
Conversation
xross
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target branch is a new one I created called
feature/xcommon_cmakefrom tag v4.5.0, which I expect to live until we release v4.6.0.Also needed a Python module version pinned to run the flake8 checks in the Jenkins job (this must have broken after v4.5.0 was released, but I remember making this same change in lots of repos).