Prepare v5.3.0#217
Merged
ACascarino merged 23 commits intorelease/v5.3.0from Jul 31, 2024
Merged
Conversation
xmosdoc v4 fixes
Add support for XCommon CMake build system on v5.2.0 and above
Include platform.h in vanilla.cpp
ACascarino
added
size:S
xhuw
reviewed
Jul 30, 2024
Comment on lines
+4
to
+5
| UNRELEASED | ||
| ---------- |
There was a problem hiding this comment.
Suggested change
| UNRELEASED | |
| ---------- | |
| 5.3.0 | |
| ----- |
xhuw
reviewed
Jul 30, 2024
| println "Unlikely these will pass.." | ||
| // warnError("Source Check"){ sourceCheck("${REPO}") } | ||
| // warnError("Changelog Check"){ xcoreChangelogCheck("${REPO}") } | ||
| stage('Basic tests') { |
xhuw
reviewed
Jul 30, 2024
| .. code-block:: console | ||
|
|
||
| $ docker pull ghcr.io/xmos/doc_builder:main | ||
| Use the `xmosdoc tool <https://github.com/xmos/xmosdoc>`_ either via docker or install it into a pip environment. |
There was a problem hiding this comment.
I see - this readme is for building the docs and is not included in the docs, I think that's fine
xhuw
approved these changes
Jul 30, 2024
xhuw
left a comment
xhuw
left a comment
There was a problem hiding this comment.
There are some questionable changes in this release
- jenkins file has step installing a bunch of stuff and then doing nothing
- readme for the doc/ directory has unnecessary amount of detail about our internal doc building tool
- xcommon_cmake support with no verification but it is mentioned in the changelog which implies it is ready
I don't think these issues need to block the release as this also includes an important fix for 15.3 tools which should be merged
Fixes for release v5.3.0
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.