Skip to content

v5.5.0 release prep#235

Merged
shuchitak merged 33 commits intodevelopfrom
release_prep
Oct 29, 2024
Merged

v5.5.0 release prep#235
shuchitak merged 33 commits intodevelopfrom
release_prep

Conversation

@shuchitak
Copy link
Copy Markdown
Contributor

No description provided.

@shuchitak shuchitak changed the title v5.4.0 release prep v5.5.0 release prep Oct 28, 2024
@xross
Copy link
Copy Markdown
Contributor

xross commented Oct 28, 2024

Please can you do a few things for me to aid publication?

There still seems to be a lot of stuff that needs tidying in this repo. Stuff I noticed:

  • I think requirements.txt needs moving (as per other repos)
  • index.rst in root of repo needs removing
  • doc structure needs making standard (programming_guide/index.rst should be lib_mic_array.rst)
  • (try and run lib_checks @ develop of infr apps as it will check settings.yml and readme)
  • Add "Development repo" section to README
  • I think the "script" directory should be "python" - according to other repos
  • examples need renaming to app_
  • is this cmake folder still needed? Its likely confusing for users
  • delete .github/ISSUE_TEMPLATE
  • delete doc/readme (we don't need to document building the docs in every repo..)
  • I don't think the document titles are consistent
  • Add references to figures

I'd like to sort out etc/vanilla and add it to the standard mic_array.h but that might have to wait for now

Sorry quite a bit!

Comment thread doc/exclude_patterns.inc
/build/*build*/**/*.md
CHANGELOG.rst
LICENSE.rst
**README*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Comment thread CHANGELOG.rst

5.5.0
-----

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to add something here with all the changes. The rename of examples at least.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread settings.yml Outdated
project: '{{lib_name}}'
title: '{{lib_name}}: PDM Microphone Arrays'
version: 5.4.0
title: '{{lib_name}}: PDM Mic Array library for the XMOS XS3 architecture'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt match the Readme title

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "PDM microphone array library"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. I ran the xmos_settings_check.py and it was happy with the settings.yml. I thought what's in Doxyfile.inc PROJECT_BRIEF needs to match settings.yml (as prompted my xmos_settings_check.py). Didn't know that settings.yml needs to match README. Maybe xmos_settings_check.py needs to check for that as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the title to PDM microphone array library

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, test needs extending I guess. For new libs id like to make lib_template or similar.

Comment thread doc/rst/lib_mic_array.rst Outdated
xross and others added 5 commits October 29, 2024 15:21
Copy link
Copy Markdown
Contributor

@xross xross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@shuchitak shuchitak merged commit b75a992 into develop Oct 29, 2024
@shuchitak shuchitak deleted the release_prep branch October 29, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants