Skip to content

Pre-release changes#260

Merged
shuchitak merged 3 commits intoxmos:developfrom
shuchitak:feature/prerelease
Feb 5, 2026
Merged

Pre-release changes#260
shuchitak merged 3 commits intoxmos:developfrom
shuchitak:feature/prerelease

Conversation

@shuchitak
Copy link
Copy Markdown
Contributor

@shuchitak shuchitak commented Feb 3, 2026

  • Update library version to v6.0.0
  • Pinned lib_board_support
  • Minor updates to documentation
  • Remove commented out code from frame_transfer.c
  • Remove dependency on lib_xassert and use <xcore/assert.h> instead
  • Changelog update

@shuchitak shuchitak force-pushed the feature/prerelease branch 3 times, most recently from 3be90a2 to 2bb5637 Compare February 3, 2026 14:31
@shuchitak shuchitak force-pushed the feature/prerelease branch 2 times, most recently from dd18802 to a438afe Compare February 3, 2026 14:55
Copy link
Copy Markdown
Contributor

@xalbertoisorna xalbertoisorna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, missing the assert change to the changelog.
Approving as no need to re-review.

Comment thread CHANGELOG.rst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGED: replaced assert.h with xcore/assert.h

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares lib_mic_array for its v6.0.0 release with dependency cleanup, code maintenance, and documentation improvements.

Changes:

  • Version updated from 5.5.0 to 6.0.0 across all build and documentation files
  • Removed dependency on lib_xassert; replaced <assert.h> with <xcore/assert.h> throughout the codebase
  • Removed commented-out code blocks from frame_transfer.c and cleaned up whitespace/formatting issues

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
settings.yml Updated version to 6.0.0
lib_mic_array/module_build_info Updated version to 6.0.0 and removed lib_xassert dependency
lib_mic_array/lib_build_info.cmake Updated version to 6.0.0 and removed lib_xassert dependency
lib_mic_array/src/mic_array_task.cpp Replaced <assert.h> with <xcore/assert.h>
lib_mic_array/src/frame_transfer.c Removed commented-out code and improved comment grammar
lib_mic_array/api/mic_array/mic_array_task.h Enhanced API documentation with clearer parameter descriptions
examples/deps.cmake Pinned lib_board_support to version 1.5.0 and removed lib_xassert dependency
examples/app_shutdown/src/main.xc Removed unused <assert.h> include
examples/app_shutdown/src/app_i2s.c Replaced <assert.h> with <xcore/assert.h>
examples/app_par_decimator/src/main.xc Removed unused <assert.h> include
examples/app_par_decimator/src/app_i2s.c Replaced <assert.h> with <xcore/assert.h>
examples/app_mic_array/src/main.xc Removed unused <assert.h> include
examples/app_mic_array/src/app_i2s.c Replaced <assert.h> with <xcore/assert.h>
examples/app_custom_filter/src/main.xc Removed unused <assert.h> include
examples/app_custom_filter/src/app_i2s.c Replaced <assert.h> with <xcore/assert.h>
tests/unit/src/test_*.cpp Replaced <assert.h> with <xcore/assert.h> and removed trailing whitespace
tests/unit/src/test_*.c Replaced <assert.h> with <xcore/assert.h> and removed trailing whitespace
tests/signal/profile/app_mips/src/main.xc Removed unused <assert.h> include
tests/custom_cmake_build/default/src/main.xc Removed unused <assert.h> include
tests/app_xcommon_build/src/main.xc Removed unused <assert.h> include
README.rst Updated version to 6.0.0
CHANGELOG.rst Updated for v6.0.0 release with reformatted text and added "REMOVED: Prefab API" entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.rst Outdated
Comment thread CHANGELOG.rst
Copy link
Copy Markdown
Contributor

@xalbertoisorna xalbertoisorna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment:

//asm volatile("testct %0, res[%1]" : "=r"(shutdown) : "r"(c_frame_out));

VERSION = 5.5.0
VERSION = 6.0.0

DEPENDENT_MODULES = lib_xcore_math(>=2.4.0) \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice getting rid of external lib and using lib_xcore

Copy link
Copy Markdown
Contributor

@ed-xmos ed-xmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuchitak shuchitak force-pushed the feature/prerelease branch 2 times, most recently from 96f0547 to 089cf13 Compare February 3, 2026 16:24
- Update library version to v6.0.0
- Pinned lib_board_support
- Update infr_apps and xmosdoc version
- Minor updates to documentation
- Remove commented out code from frame_transfer.c
- Remove dependency on lib_xassert and use <xcore/assert.h> instead
- Changelog update
@shuchitak shuchitak requested a review from aramponx February 4, 2026 09:48
Copy link
Copy Markdown
Contributor

@xalbertoisorna xalbertoisorna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Comment thread lib_mic_array/src/mic_array_task.cpp Outdated
Comment on lines 22 to 23
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go away?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, which bit? I dont see anything in mic_array_task.cpp that needs to go away

@shuchitak shuchitak merged commit 73d5f9e into xmos:develop Feb 5, 2026
2 checks passed
@shuchitak shuchitak deleted the feature/prerelease branch February 5, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants