Merged
Conversation
3be90a2 to
2bb5637
Compare
dd18802 to
a438afe
Compare
xalbertoisorna
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
CHANGED: replaced assert.h with xcore/assert.h
There was a problem hiding this comment.
Pull request overview
This PR prepares lib_mic_array for its v6.0.0 release with dependency cleanup, code maintenance, and documentation improvements.
Changes:
- Version updated from 5.5.0 to 6.0.0 across all build and documentation files
- Removed dependency on lib_xassert; replaced
<assert.h>with<xcore/assert.h>throughout the codebase - Removed commented-out code blocks from frame_transfer.c and cleaned up whitespace/formatting issues
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.yml | Updated version to 6.0.0 |
| lib_mic_array/module_build_info | Updated version to 6.0.0 and removed lib_xassert dependency |
| lib_mic_array/lib_build_info.cmake | Updated version to 6.0.0 and removed lib_xassert dependency |
| lib_mic_array/src/mic_array_task.cpp | Replaced <assert.h> with <xcore/assert.h> |
| lib_mic_array/src/frame_transfer.c | Removed commented-out code and improved comment grammar |
| lib_mic_array/api/mic_array/mic_array_task.h | Enhanced API documentation with clearer parameter descriptions |
| examples/deps.cmake | Pinned lib_board_support to version 1.5.0 and removed lib_xassert dependency |
| examples/app_shutdown/src/main.xc | Removed unused <assert.h> include |
| examples/app_shutdown/src/app_i2s.c | Replaced <assert.h> with <xcore/assert.h> |
| examples/app_par_decimator/src/main.xc | Removed unused <assert.h> include |
| examples/app_par_decimator/src/app_i2s.c | Replaced <assert.h> with <xcore/assert.h> |
| examples/app_mic_array/src/main.xc | Removed unused <assert.h> include |
| examples/app_mic_array/src/app_i2s.c | Replaced <assert.h> with <xcore/assert.h> |
| examples/app_custom_filter/src/main.xc | Removed unused <assert.h> include |
| examples/app_custom_filter/src/app_i2s.c | Replaced <assert.h> with <xcore/assert.h> |
| tests/unit/src/test_*.cpp | Replaced <assert.h> with <xcore/assert.h> and removed trailing whitespace |
| tests/unit/src/test_*.c | Replaced <assert.h> with <xcore/assert.h> and removed trailing whitespace |
| tests/signal/profile/app_mips/src/main.xc | Removed unused <assert.h> include |
| tests/custom_cmake_build/default/src/main.xc | Removed unused <assert.h> include |
| tests/app_xcommon_build/src/main.xc | Removed unused <assert.h> include |
| README.rst | Updated version to 6.0.0 |
| CHANGELOG.rst | Updated for v6.0.0 release with reformatted text and added "REMOVED: Prefab API" entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xalbertoisorna
requested changes
Feb 3, 2026
ed-xmos
reviewed
Feb 3, 2026
| VERSION = 5.5.0 | ||
| VERSION = 6.0.0 | ||
|
|
||
| DEPENDENT_MODULES = lib_xcore_math(>=2.4.0) \ |
Contributor
There was a problem hiding this comment.
Nice getting rid of external lib and using lib_xcore
96f0547 to
089cf13
Compare
- Update library version to v6.0.0 - Pinned lib_board_support - Update infr_apps and xmosdoc version - Minor updates to documentation - Remove commented out code from frame_transfer.c - Remove dependency on lib_xassert and use <xcore/assert.h> instead - Changelog update
089cf13 to
8b52d79
Compare
aramponx
approved these changes
Feb 4, 2026
e186f29 to
879996a
Compare
xalbertoisorna
approved these changes
Feb 4, 2026
Comment on lines
22
to
23
Contributor
There was a problem hiding this comment.
this should go away?
Contributor
Author
There was a problem hiding this comment.
sorry, which bit? I dont see anything in mic_array_task.cpp that needs to go away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.