Fix bug due to overwriting of asrc_io->input_timestamp #125
Fix bug due to overwriting of asrc_io->input_timestamp #125shuchitak merged 11 commits intoxmos:developfrom
Conversation
| while(1){ | ||
| // Wait for block of samples. We will get the buffer index of the newly written samples from receive_asrc_input_samples_cb | ||
| unsigned input_write_idx = (unsigned)chanend_in_byte(c_buff_idx); | ||
| int32_t save_timestamp = asrc_io->input_timestamp; |
There was a problem hiding this comment.
HI, as discussed I think this should be double buffered in the asrc_io struct ideally. Although arguably this is all hidden from the user.
You did mention something about an issue with that approach?
There was a problem hiding this comment.
hey @ed-xmos, no issue as such. I'd mentioned that doing it the double buffer way would require more lines of code change since we're changing the asrc_in_out_t struct. It'll require change in lib_src as well as any applications that use it (an02003 for example). I do agree that that's a better fix so will do it the double buffer way and make the change everywhere.
| 2.6.0 | ||
| ----- | ||
|
|
||
| * CHANGED: Double buffer asrc_io.input_timestamp to prevent producer timestamp |
There was a problem hiding this comment.
Probably a fix rather than a change?
There was a problem hiding this comment.
Also, looks like an API change to me (xscope_used)
ed-xmos
left a comment
ed-xmos
left a comment
There was a problem hiding this comment.
Looks great - only suggested change is the changelog entry type
3 participants
Uh oh!
There was an error while loading. Please reload this page.