Add braces to initialisation list to avoid warnings when building#33
Merged
samchesney merged 2 commits intoxmos:masterfrom Jul 1, 2019
Merged
Add braces to initialisation list to avoid warnings when building#33samchesney merged 2 commits intoxmos:masterfrom
samchesney merged 2 commits intoxmos:masterfrom
Conversation
Altered the braces in initialisation lists to match the underlying arrangement of nested lists. The defined type (typedef) of the array includes a list which the initialisation lists did not take into account.
samchesney
approved these changes
Jul 1, 2019
Contributor
samchesney
left a comment
samchesney
left a comment
There was a problem hiding this comment.
This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ASRCFiltersIDs_tandSSRCFiltersIDs_ttypes each contain an array. The initialisation lists for variables either of these types did not take that additional array into account when grouping initial values with braces, leading to compiler warnings when building. This pull request adds in the missing braces.