Skip to content

Tidy Api #31

Merged
xross merged 5 commits intoxmos:developfrom
xross:tidy_api
Jul 26, 2022
Merged

Tidy Api #31
xross merged 5 commits intoxmos:developfrom
xross:tidy_api

Conversation

@xross
Copy link
Copy Markdown
Contributor

@xross xross commented Jul 20, 2022 •
edited
Loading

  • Further strip out old xmostest framework
  • Make API a bit more user-friendly (more like original xmostest). Unfortunately does mean it is reliant on pytest capfd fixture. Perhaps some future work can make this more generic or make use of the out outcapture.py

@xross xross requested a review from danielpieczko July 21, 2022 12:08
@xross xross mentioned this pull request Jul 21, 2022
Merged
1 task
@xross xross requested a review from ACascarino July 21, 2022 12:12
danielpieczko
danielpieczko reviewed Jul 21, 2022
View reviewed changes
Comment thread lib/python/Pyxsim/__init__.py Outdated
Comment thread lib/python/Pyxsim/__init__.py Outdated
ACascarino
ACascarino suggested changes Jul 21, 2022
View reviewed changes
Comment thread lib/python/Pyxsim/__init__.py Outdated
@xross
Copy link
Copy Markdown
Contributor Author

xross commented Jul 22, 2022

Fixed issues as reported.

@xross xross requested a review from danielpieczko July 26, 2022 10:46
@xross xross merged commit 41f06e1 into xmos:develop Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ACascarino ACascarino ACascarino approved these changes

@danielpieczko danielpieczko danielpieczko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xross @ACascarino @danielpieczko